P3D v4 ACM updating AutogenDescriptions.spb despite addon deactivated

Arno,

Through my testing of adding new vegetation, I just noticed that ACM is updating the AutogenDescriptions.spb file even if there are no add-on sceneries activated. The only way to prevent this is to delete the add-on from the Scenery Library. I thought this was addressed? I d/l the latest version just a few moments ago to confirm I have the latest version. The file AutogenConfigurationMerger.exe is dated 1/10/2019.
 

arno

Administrator
Staff member
FSDevConf team
Resource contributor
Let me check the source code. Do you add the scenery via the scenery.cfg or an add-on.xml file?
 
This was tested with the Scenery.cfg. I will test with the add-on.xml method.

Update Arno - Yes, using the add-on.xml method will also update the AutogenDescriptions.spb file even if the add-on is deactivated. So both methods have the issue.
 
Last edited:

arno

Administrator
Staff member
FSDevConf team
Resource contributor
The check is not there indeed, I'll add it. For the scenery.cfg that is easy, for the add-on.xml I can't find any command to disable them.
 
Oh, that's interesting. If you cannot find a command for it I am not sure what impact this may have on a released add-on? I discovered it when I was testing/making slight changes to my custom autogen files and noticed I was losing all vegetation due to a clash with a deactivated scenery.
 

arno

Administrator
Staff member
FSDevConf team
Resource contributor
I am not sure how a clash with a deactivated scenery can give issues. Or was it a deactivated version of your own scenery?

How did you deactivate the add-on.xml based scenery btw, I think that can only be done by moving or renaming the xml file.
 
This was tested in P3Dv4.5. I have two add-ons I created. Call them addon1 and addon2. They are both installed via the Scenery Library (scenery.cfg) method. Both have the same custom autogendescriptions.xml files in their own autogen folder ready for use in ACM. I deactivated (unchecked) addon1 and I made edits edits on addon2's autogendescription.xml file for testing.

If I run P3D ACM reads both addon1 and addon2 files even if addon1 is deactivated. Now for the "clash", I cannot give an exact account and I was trying several xml edits. The result when in P3D was not vegetation at all. If I remove (delete), addon1 from the Scenery Library and run P3D again the vegetation appears again.

Of course my xml edits as I test are causing the "clash" (probably a better term since crash may be mistaken as P3D crashing which is not the case). But I would have to remove all my addon sceneries each time I test new xml scripts. I should only have to deactivate them.

With the add-on.xml in the P3D addon screen (window) you have the option to check/uncheck to make it active or not. I simply unchecked it and made sure there were no other sceneries using ACM. When I ran a fresh test ACM was still updating based on that one deactivated addon.xml scenery.

Hope that clarifies
 

arno

Administrator
Staff member
FSDevConf team
Resource contributor
For the scenery.cfg method I have changed the code now. I will get a new release out when I'm clear on the add-on.xml issue as well.
 

arno

Administrator
Staff member
FSDevConf team
Resource contributor
OK, I have found it where the active state of the add-on.xml sceneries is stored. That is in the file add-ons.cfg in the folder C:\ProgramData\Lockheed Martin\Prepar3D v4. So I'll have to modify ACM to also read that folder to check if an addon is active or not.
 

arno

Administrator
Staff member
FSDevConf team
Resource contributor
Hi,

Here is a new beta build that should read the add-ons.cfg file correctly. Can you check if it works for you?
 
I will try to check it out tonight when I get home from work. Maybe we can use my script as an example. I would need to clean it up and make it more generic like a template. That may save you some time and I would think it would help fellow developers who go through this for the first time.
 

arno

Administrator
Staff member
FSDevConf team
Resource contributor
If I can use your file as example that would be fine. I can make it more generic by changing names, etc.
 
Arno, after testing both methods I can say the new ACM version is working as expected now. I have also attached a sample of a custom AutogenDescription that I think you can use/adapt for the manual. Thanks for all your help on rectifying this.
 

Attachments

arno

Administrator
Staff member
FSDevConf team
Resource contributor
Thanks for the feedback, I'll try to make an official release soon. And try to add a sample to the manual.
 

arno

Administrator
Staff member
FSDevConf team
Resource contributor
I have removed the beta build here, since I have uploaded it as official release now.

You don't have to download it again, I only changed the manual, the EXE has not changed.
 
Top