Calling multi-smoke entries

[DragonflightDesign]

Given this in the aircraft.cfg file:

[SMOKESYSTEM]
smoke.0= -14.00, 0.00, 0.00, fx_dummy
smoke.1= -18.40,-0.29,-2.95, fx_AOA_red
smoke.2= -18.40,-0.29,-2.71, fx_AOA_green
smoke.3= -18.40,-0.29,-2.83, fx_AOA_amber
smoke.4= -66.00,-1.80, 0, fx_fsxba_smoke_w
smoke.5= -68.50,-1.80, 0, fx_F18_EG_Smoke_L_NORM
smoke.6= -68.50, 1.80, 0, fx_F18_EG_Smoke_R_NORM
smoke.7= -63.00,-1.80, 0, fx_F18_HeatShimmer_L
smoke.8= -63.00, 1.80, 0, fx_F18_HeatShimmer_R

How would you call the individual entries using execute_calculator_code? Bear in mind that I've never had any success in setting XML vars using execute_calculator_code so yes, this is a blatant request for an example of working code

 

[WarpD]

What var(s) are you trying to set?

 

[JB3DG]

I wouldn't use execute_calculator_code. I would use trigger_key_event to write (KEY_SMOKE_ON/OFF events) and aircraft_varget to read (use the index parameter to read the state of the desired channel).

 

[DragonflightDesign]

@WarpD: SMOKE_ON/OFF, but how would you tell it to select the required smoke.x listing?

@JB3DG: That would be one way of doing it.

Brain kicked into gear about twenty minutes ago. Another way would be to wrap the smoke functions in an XML file (as per Fr. Bill's code in the topic https://www.fsdeveloper.com/forum/threads/independent-multiple-smoke-fx.14592/#post-94271) and then use register_named_variable to call the XML gauge as required. I really wanted to keep all code within the C-gauge, but this is likely to be the best solution.

I'd still like an answer to my base question if possible: an example of using execute_calculator_code to set an A:var using a K:var (or is it the other way round???).

 

[WarpD]

Maybe something like this:

        char str[40];

        sprintf_s(str,40,"%d (>K:SMOKE_ON)",1);
        execute_calculator_code(str,NULL, NULL, NULL);

 

[DragonflightDesign]

Thanks Ed.

 

[WarpD]

If that doesn't work at all... try this:

        char str[40];

        sprintf_s(str,40,"%d (>K:SMOKE_ON, number)",1);
        execute_calculator_code(str,NULL, NULL, NULL);

 

[DragonflightDesign]

Aha! That looks... as if it could be bloody marvellous. I'll report back tomorrow.

 

[WarpD]

It's tomorrow... [runs away!]

 

[DragonflightDesign]

Well, the test code might be...

void selectSmoke(bool action, int number)
{
    char str[40];
    static int check = 0;

    if (action == true && check == 0)
    {
        check = 1;
        sprintf_s(str, 40, "%d (>K:SMOKE_ON, number)", 1);
        execute_calculator_code(str, NULL, NULL, NULL);
    }

    if (action == false && check == 1)
    {
        check = 0;
        sprintf_s(str, 40, "%d (>K:SMOKE_OFF, number)", 1);
        execute_calculator_code(str, NULL, NULL, NULL);
    }
    return;
}

..but for some reason the smoke turns itself off as soon as I turn it on . Working on it...

[Edit] This didn't work either:

        sprintf_s(str, "%d%s", number, " (>K:SMOKE_ON)", 1);
        execute_calculator_code(str, NULL, NULL, NULL);

 

[Misho]

I've been using this forever and it works:

void    SetLVar_Bool(INT32 Var, string LVar)
{
    char cTemp[60];
    sprintf_s(cTemp, "%d%s", Var, LVar.c_str());
    PCSTRINGZ szString = cTemp;
    execute_calculator_code(szString, NULL, NULL, NULL);
}

...and the usage in my case:

SetLVar_Bool(MFDState->switch_MFD_ON_OFF, " (>L:TB_GenericVar_01,bool)");

Or, in your case:

SetLVar_Bool(1, " (>K:SMOKE_ON)");

Hope that helps...

 

[WarpD]

Just so we're clear the '1' in this code:

sprintf_s(str, 40, "%d (>K:SMOKE_ON, number)", 1);

is the value being passed with the SMOKE_ON event. So if you want to trigger a different smoke entry... you would need to use a different number.

 

[DragonflightDesign]

Plenty to look at tomorrow - thank you, both of you.

 

[Gypsy Baron]

I used an XML gauge to enable multiple smoke effects.

A typical statement has this form:

N (>K:SMOKE_SET)

where N = the smoke.x number + 1

 

[DragonflightDesign]

@Gypsy Baron: Generally I don't do XML unfortunately - I'm resolutely old-school pure-C code unless I can't avoid it. Then I usually mangle somebody else's XML code until it does what I want it to do

@WarpD @Misho: It looks like our MDL guys have told me what they intend to do, not what they have done. This could go a loooong way to explaining why things don't work... Update will follow.

 

[spokes2112]

Not to "beat a dead horse" but in a lot cases I've seen the programmer / "do it yourselfer" has never has checked the current smoke state prior to the command.
It's a virus in one forum - "use this"
Suddenly exits don't work, other gauges suffer etc.. Flooding.

I wouldn't use execute_calculator_code. I would use trigger_key_event to write (KEY_SMOKE_ON/OFF events) and aircraft_varget to read (use the index parameter to read the state of the desired channel).

Just to add a little, in XML, an excerpt from my code template library:

Spoiler

<!-- AIRCRAFT.CFG NOTES

[SMOKESYSTEM]
//smoke.0 = DO NOT USE
smoke.1 = 0.00,  0.00,  0.00,  EFFECT #1
smoke.2 = 0.00,  0.00,  0.00,  EFFECT #2
smoke.3 = 0.00,  0.00,  0.00,  EFFECT #3
etc..
smoke.99 = 0.00,  0.00,  0.00,  EFFECT #99

-->

<Macro Name="SMK_CTRL">
    if{ (A:SMOKE ENABLE:@1, bool) 0 == if{ @1 (>K:SMOKE_ON) } } els{ (A:SMOKE ENABLE:@1, bool) 0 != if{ @1 (>K:SMOKE_OFF) } }
</Macro>

<!-- THE MACRO CALL
ON, WHERE X IS THE SMOKE NUMBER IN AIRCRAFT.CFG
1 @SMK_CTRL(X)

OFF, WHERE X IS THE SMOKE NUMBER IN AIRCRAFT.CFG
0 @SMK_CTRL(X) :
-->

<!-- EXAMPLE, USING THE MACRO: A HEAT PLUME IF ENGINE 1 IS RUNNING ON SMOKE 9 -->
<Element Name="Engine 1 Heat Plume">
    <Select>
        <Value>
            (A:ENG COMBUSTION:1, bool) @SMK_CTRL(9)              
        </Value>
    </Select>
</Element>

<!-- EXAMPLE, CODED IN NORMAL STYLE: A HEAT PLUME IF ENGINE 1 IS RUNNING ON SMOKE 9 -->
<Element Name="Engine 1 Heat Plume">
    <Select>
        <Value>
            (A:ENG COMBUSTION:1, bool)
            if{
                (A:SMOKE ENABLE:9, bool) 0 ==
                if{
                    9 (>K:SMOKE_ON)
                }
            }
            els{
                (A:SMOKE ENABLE:9, bool) 0 !=
                if{
                    9 (>K:SMOKE_OFF)
                }  
            }
        </Value>
    </Select>
</Element>

 

[DragonflightDesign]

I fell foul of that general problem in the early days. Doing a check before acting also speeds up code execution. Admittedly, the above test code is just a block check, but it is only test code.